Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotbugs exclusion for JDK flow #917

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@NiteshKant
Copy link
Member

NiteshKant commented Jan 10, 2020

Motivation

ServiceTalk Subscriber allows passing null values in onNext but JDK flow does not provide any guidance hence defaulting to non-null. Spotbugs does not like this inconsistency but does not complain consistently (ironically 馃檪)

Modification

As this is an expected situation for the JDK flow adapter, add a spotbugs exclusion.

Result

Spotbugs does not complain for this intentional inconsistency.

__Motivation__

ServiceTalk `Subscriber` allows passing `null` values in `onNext` but JDK flow does not provide any guidance hence defaulting to non-null. Spotbugs does not like this inconsistency but does not complain consistently (ironically 馃檪)

__Modification__

As this is an expected situation for the JDK flow adapter, add a spotbugs exclusion.

__Result__

Spotbugs does not complain for this intentional inconsistency.
@NiteshKant NiteshKant requested a review from idelpivnitskiy Jan 10, 2020
Copy link
Member

idelpivnitskiy left a comment

Spotbugs...

@NiteshKant NiteshKant merged commit f0e6c0b into apple:master Jan 10, 2020
3 checks passed
3 checks passed
pull request validation (jdk11) Build finished.
Details
pull request validation (jdk8) Build finished.
Details
pull request validation (quality) Build finished.
Details
@NiteshKant NiteshKant deleted the NiteshKant:jdk-flow-spot branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.