Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to the latest versions #922

Merged
merged 1 commit into from Jan 17, 2020

Conversation

@idelpivnitskiy
Copy link
Member

idelpivnitskiy commented Jan 17, 2020

No description provided.

@idelpivnitskiy idelpivnitskiy requested review from jayv and NiteshKant Jan 17, 2020
@@ -322,7 +322,7 @@ private Queues() {
}

static <T> Queue<T> newUnboundedLinkedMpscQueue() {
return USE_UNSAFE_QUEUES ? MpscLinkedQueue.newMpscLinkedQueue()
return USE_UNSAFE_QUEUES ? new MpscLinkedQueue<>()

This comment has been minimized.

Copy link
@NiteshKant

NiteshKant Jan 17, 2020

Member

Was this an API change in jctools?

This comment has been minimized.

Copy link
@Scottmitch

Scottmitch Jan 17, 2020

Member

jctools update was a major version bump (e.g. 2.x -> 3.x) so API breaking is fair. However the package name didn't change so this may result in collisions at runtime and the and maven coordinates didn't change so this may cause trouble for build tools at compile time during the transition period... /cc @nitsanw

This comment has been minimized.

Copy link
@idelpivnitskiy

idelpivnitskiy Jan 17, 2020

Author Member

yep, they had minor API changes: https://github.com/JCTools/JCTools/blob/master/RELEASE-NOTES.md#300
@Scottmitch @NiteshKant will you suggest to not update for now? Netty 4.1.45 depends on jctools 2.x, the next netty version will use 3.0.0. We can update it later to make it consistent with netty: netty/netty@8410b08

This comment has been minimized.

Copy link
@idelpivnitskiy

idelpivnitskiy Jan 17, 2020

Author Member

however, there were no api changes made in netty, so we should be good either way

This comment has been minimized.

Copy link
@NiteshKant

NiteshKant Jan 17, 2020

Member

AFAIR netty shades jctools so we should be fine. Lets update

@idelpivnitskiy idelpivnitskiy merged commit 464554a into apple:master Jan 17, 2020
3 checks passed
3 checks passed
pull request validation (jdk11) Build finished.
Details
pull request validation (jdk8) Build finished.
Details
pull request validation (quality) Build finished.
Details
@idelpivnitskiy idelpivnitskiy deleted the idelpivnitskiy:upd-versions branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.