Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude `servicetalk-concurrent-jdkflow` from JDK8 javadoc #927

Merged
merged 1 commit into from Jan 23, 2020

Conversation

@idelpivnitskiy
Copy link
Member

idelpivnitskiy commented Jan 23, 2020

Motivation:

servicetalk-concurrent-jdkflow depends on JDK9+, we have
to exclude it from gradle's javadocAll task that we create
for the root project.

Modifications:

  • Exclude servicetalk-concurrent-jdkflow from JDK8 javadoc;

Result:

javadocAll doesn't fail on JDK8.

Motivation:

`servicetalk-concurrent-jdkflow` depends on JDK9+, we have
to exclude it from gradle's `javadocAll` task that we create
for the root project.

Modifications:

- Exclude `servicetalk-concurrent-jdkflow` from JDK8 javadoc;

Result:

`javadocAll` doesn't fail on JDK8.
@idelpivnitskiy idelpivnitskiy requested review from jayv and Scottmitch Jan 23, 2020
@Scottmitch Scottmitch merged commit 16e5bf0 into apple:master Jan 23, 2020
0 of 3 checks passed
0 of 3 checks passed
pull request validation (jdk11) Build started for merge commit.
Details
pull request validation (jdk8) Build started for merge commit.
Details
pull request validation (quality) Build started for merge commit.
Details
@idelpivnitskiy idelpivnitskiy deleted the idelpivnitskiy:exclude-jdkflow branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.