Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher#range operator #961

Merged
merged 3 commits into from Mar 11, 2020
Merged

Publisher#range operator #961

merged 3 commits into from Mar 11, 2020

Conversation

@Scottmitch
Copy link
Member

Scottmitch commented Mar 10, 2020

Motivation:
The canonocal way to do an asynchornous for lop with integer indexes in reactive streams is to use a range() operator. We currently don't have a range operator.

Modifications:

  • Add Publisher#range(int begin, int end)
  • Add Publisher#range(int begin, int end, int stride)

Result:
For loops with integer indexes can be done directly with Publisher#range(..)

Motivation:
The canonocal way to do an asynchornous for lop with integer indexes in reactive streams is to use a range() operator. We currently don't have a range operator.

Modifications:
- Add Publisher#range(int begin, int end)
- Add Publisher#range(int begin, int end, int stride)

Result:
For loops with integer indexes can be done directly with Publisher#range(..)
@Scottmitch Scottmitch requested review from NiteshKant and idelpivnitskiy Mar 10, 2020
@Scottmitch Scottmitch requested a review from normanmaurer Mar 10, 2020
Copy link
Member

NiteshKant left a comment

Suggestion to include a test but otherwise LGTM

@Scottmitch Scottmitch merged commit fffe9a1 into apple:master Mar 11, 2020
3 checks passed
3 checks passed
pull request validation (jdk11) Build finished.
Details
pull request validation (jdk8) Build finished.
Details
pull request validation (quality) Build finished.
Details
@Scottmitch Scottmitch deleted the Scottmitch:publisher_range branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.