Add ToolchainLanguageServerCrashHandler to handle crashes
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handler will be responsible for handling the crash: - Inform the user of the crash - Log the crash - Choosing to restart the `ToolchainLanguageServer` or disabling it
|
@swift-ci please test |
benlangmuir
reviewed
Oct 29, 2019
| /// | ||
| /// The handler may or may not chose to re-open previously open documents and/or | ||
| /// stop sending any further requests to the given `ToolchainLanguageServer`. | ||
| func handleCrash(_ languageService: ToolchainLanguageServer, _ debugInfo: String) |
There was a problem hiding this comment.
What's the idea for the debug info parameter? Right now I see it's always a fixed string - where would we get more information to pass here?
|
Closing since this is no longer a priority (may re-open later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler will be responsible for handling the crash:
ToolchainLanguageServerordisabling it