Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

ppc64le port. #167

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Conversation

asowani
Copy link
Contributor

@asowani asowani commented Mar 8, 2018

As mentioned in #160 I am merging ppc64le changes to "upstream-with-swift" branch first. Please review.

@asowani asowani mentioned this pull request Mar 8, 2018
@aschwaighofer
Copy link
Member

Does the PPC backend support swifterror?

A quick check seems to indicate that it does not:

$ git show origin/upstream-with-swift:lib/Target/PowerPC/PPCCallingConv.td | grep Swift

If it does not support swifterror it is more likely that

bool isSwiftErrorInRegister() const override {    
  return false;
}

will work correctly.

@asowani
Copy link
Contributor Author

asowani commented Mar 9, 2018

@aschwaighofer Thanks for reviewing code changes, I have done required modifications and have committed again.

Copy link
Member

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@asowani
Copy link
Contributor Author

asowani commented Mar 27, 2018

Hi! Any idea when this PR will be merged? Thanks!

@bob-wilson
Copy link
Contributor

We should have mentioned this sooner, but ideally this change should be applied to the llvm.org version of Clang. We really should have this version get out of sync with trunk more than it already is. But, since no one told you that until now, I don't want to block your progress. As a compromise, if we merge this now, can you add this change on reviews.llvm.org?

@asowani
Copy link
Contributor Author

asowani commented Mar 28, 2018

@bob-wilson Sure, I will initiate process to add these changes to llvm.org right away. Thanks!

@bob-wilson bob-wilson merged commit deda166 into apple:upstream-with-swift Mar 28, 2018
@bob-wilson
Copy link
Contributor

OK. I went ahead and merged this then.

@bob-wilson
Copy link
Contributor

I pulled the change over to swift-4.2-branch (#171) and it will be automatically merged from there into stable.

@asowani
Copy link
Contributor Author

asowani commented Mar 29, 2018

@bob-wilson Thanks! I have started upstreaming changes to llvm.

jonpspri pushed a commit to jonpspri/swift-clang that referenced this pull request Apr 4, 2018
@bob-wilson
Copy link
Contributor

I haven't seen a patch sent to Clang at llvm.org yet. Can you please do that soon?

@asowani
Copy link
Contributor Author

asowani commented Apr 18, 2018 via email

@asowani
Copy link
Contributor Author

asowani commented Apr 24, 2018

@bob-wilson I got clearance from my employer to upstream code changes to LLVM. I've filed a new bug for this in LLVM bugzilla: https://bugs.llvm.org/show_bug.cgi?id=37223

@asowani
Copy link
Contributor Author

asowani commented Apr 25, 2018

@bob-wilson I have uploaded the patch to the bug which I created yesterday. (https://bugs.llvm.org/show_bug.cgi?id=37223)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants