Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place a time limit on TestFileHandle.test_readWriteHandlers() #2259

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
1 participant
@brentdax
Copy link
Contributor

commented May 13, 2019

This test seems to sometimes fail, which can make it hang forever. Give it a still-generous-but-not-infinite timeout so it at least fails gracefully when it fails.

Fixes SR-10680 and rdar://problem/50735595.

@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@swift-ci test

Place a time limit on TestFileHandle.test_readWriteHandlers()
This test seems to sometimes fail, which can make it hang forever. Give it a still-generous-but-not-infinite timeout so it at least fails gracefully when it fails.

https://bugs.swift.org/browse/SR-10680

@brentdax brentdax force-pushed the brentdax:proximate-future branch from 546218d to e80678b May 13, 2019

@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@swift-ci please test linux platform

1 similar comment
@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@swift-ci please test linux platform

@brentdax brentdax merged commit 5279760 into apple:master May 14, 2019

1 check passed

Swift Test Linux Platform
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.