New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ARMv6 on linux #352

Merged
merged 1 commit into from May 11, 2016

Conversation

Projects
None yet
3 participants
@pj4533
Contributor

pj4533 commented May 7, 2016

This change expands on the work by @hpux735 to support ARMv6, not just ARMv7.

While making the change I noticed the ArchSubType class (which already has a bunch of ARM architectures listed). That might be a more robust change...but ArchSubType doesn't look like its used anywhere, so I did this quicker solution that I know works.

Thoughts on whether it is worth it to try an implementation with the arm ArchType, and manage the v6 or v7 in the ArchSubType? It makes things more complicated (have to add a subarch to Target, etc), so maybe better just use ArchType only (as I have done here)?

@hpux735

This comment has been minimized.

Show comment
Hide comment
@hpux735

hpux735 May 10, 2016

Contributor

This successfully built on the un-official swift-arm CI infrastructure. It should be NFC on any other arch. LGTM.

Contributor

hpux735 commented May 10, 2016

This successfully built on the un-official swift-arm CI infrastructure. It should be NFC on any other arch. LGTM.

@parkera

This comment has been minimized.

Show comment
Hide comment
@parkera

parkera May 10, 2016

Member

@swift-ci please test

Member

parkera commented May 10, 2016

@swift-ci please test

@parkera

This comment has been minimized.

Show comment
Hide comment
@parkera

parkera May 10, 2016

Member

Just to make sure we didn't mess something up for the other build platforms, I'll kick off a CI run.

Member

parkera commented May 10, 2016

Just to make sure we didn't mess something up for the other build platforms, I'll kick off a CI run.

@parkera parkera merged commit a1ea7f7 into apple:master May 11, 2016

1 check passed

Swift Test Linux Platform Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment