Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SE-0121] remove use of optional comparison operators #464

Merged
merged 1 commit into from Jul 24, 2016

Conversation

jtbandes
Copy link
Collaborator

Found another. These things are out to get me. for apple/swift#3637

@jtbandes
Copy link
Collaborator Author

@parkera Can I bother you for another CI run?

@parkera
Copy link
Member

parkera commented Jul 22, 2016

@swift-ci please test

@jtbandes
Copy link
Collaborator Author

jtbandes commented Jul 22, 2016

@ddunbar Any idea what this failure means? I think it's coming from the package manager:

https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/142/console

Test Case 'GitRepositoryTests.testProvider' started at 21:21:54.891
Cloning /tmp/spm-tests-testProvider().IEkqjp/test-repo
fatal: Needed a single revision
error: Git 2.0 or higher is required. Please update git and retry

Maybe it's flaky and just running again would fix it?

@ddunbar
Copy link
Member

ddunbar commented Jul 22, 2016

No, it is a real failure which has been reverted.

@moiseev
Copy link
Contributor

moiseev commented Jul 22, 2016

@swift-ci please test

@moiseev
Copy link
Contributor

moiseev commented Jul 23, 2016

Build failure looks unrelated.
@parkera can we proceed and merge? As this one is blocking apple/swift#3637

@moiseev
Copy link
Contributor

moiseev commented Jul 23, 2016

Master builds are failing with the same error.

@moiseev
Copy link
Contributor

moiseev commented Jul 24, 2016

@swift-ci Please test and merge

@jtbandes
Copy link
Collaborator Author

@moiseev still seems like a probably unrelated failure?

@moiseev moiseev merged commit a7e543a into apple:master Jul 24, 2016
@jtbandes jtbandes deleted the se-0121 branch July 24, 2016 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants