Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6183] Use CMake for building Corelibs XCTest #365

Closed
briancroom opened this issue Oct 19, 2017 · 6 comments
Closed

[SR-6183] Use CMake for building Corelibs XCTest #365

briancroom opened this issue Oct 19, 2017 · 6 comments

Comments

@briancroom
Copy link
Collaborator

@briancroom briancroom commented Oct 19, 2017

Previous ID SR-6183
Radar None
Original Reporter @briancroom
Type Task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s XCTest
Labels Task, Linux
Assignee None
Priority Medium

md5: 55b6c9013e4d23dd5c8eb5cbe99605d3

Issue Description:

While the long-term goal is still to make SwiftPM the primary way to build Corelibs XCTest, in the meantime, it would be great for the project to get incremental builds instead of always rebuilding the entire library as happens currently. It seems that adopting CMake would be the most pragmatic way to achieve this, and would be in keeping with other Swift.org projects. (e.g. libdispatch which recently switched over to CMake.)

@briancroom
Copy link
Collaborator Author

@briancroom briancroom commented Oct 19, 2017

@modocache
Copy link
Mannequin

@modocache modocache mannequin commented Oct 20, 2017

Awesome, I'd be very excited to see this happen! t_martinho (JIRA User) has been doing some work in corelibs-xctest recently, maybe he'd be interested in trying this?

I think the pull requests that added a CMake build system to corelibs-libdispatch would be handy to reference here:

I think a good first step would be to write CMake similar to the Swift support from apple/swift-corelibs-libdispatch#243 I'm wondering whether we should be trying to share any of the Swift build logic between these two projects, but I think that for an initial pull request that should be a non-goal.

@aciidb0mb3r
Copy link
Member

@aciidb0mb3r aciidb0mb3r commented Oct 20, 2017

I'll give this a try.

@aciidb0mb3r
Copy link
Member

@aciidb0mb3r aciidb0mb3r commented Oct 24, 2017

Highly WIP PR: #206

@stmontgomery
Copy link
Contributor

@stmontgomery stmontgomery commented Aug 16, 2018

The PR above was closed yesterday, can this issue be closed?

@compnerd
Copy link
Collaborator

@compnerd compnerd commented Nov 28, 2018

XCTest was ported to CMake a while ago.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants