Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with a private module cache #270

Conversation

Projects
None yet
3 participants
@brentdax
Copy link
Contributor

commented May 14, 2019

We currently believe that the reason Linux CI is so prone to module-loading failures is that different jobs with slightly different compilers may end up using the same system-wide module cache directories. If so, using -module-cache-path to point to a directory specific to the working copy should improve CI reliability.

This PR modifies Corelibs XCTest's lit configuration to run swift with a -module-cache-path $BUILT_PRODUCTS_DIR/XCTest.dir/ModuleCache argument, contributing to this solution.

Fixes https://bugs.swift.org/browse/SR-10665.

@brentdax

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@swift-ci please test

@brentdax brentdax requested a review from shahmishal May 14, 2019

@shahmishal shahmishal requested a review from briancroom May 14, 2019

@briancroom
Copy link
Collaborator

left a comment

Makes sense. Thanks for the patch!

@briancroom briancroom merged commit e05c7e2 into apple:master May 14, 2019

2 checks passed

Swift Test Linux Platform Build finished.
Details
Swift Test OS X Platform Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.