Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[XCTestObservation] Add XCTestSuite announcements #84
What's in this pull request?
swift-corelibs-xctest did not already defined
Apple XCTest allows
Why merge this pull request?
What are the downsides of merging this pull request?
added a commit
this pull request
Mar 28, 2016
referenced this pull request
Mar 28, 2016
This seems like a reasonable first step. I agree generally with your assessment in the second "downside" you mention. The weirdness around having the "All" suite and the bundle suite be peers in a list of root suites instead of having a containment relationship arises from this, I guess. I would definitely like to see continued movement towards having test suites constructed and then used to control the running of the tests instead of just being constructed in order to send the observations. But I am OK with taking this in incremental stages.
Here's the error from Linux CI:
@mike-ferris-apple I've resolved the Linux build issue. Could you ask @swift-ci to please test? If the tests pass, I'll merge this to achieve the "incremental stages" you describe (or you can request "@swift-ci please test and merge").
#86 is the realization of the "continued movement towards having test suites constructed and then used to control the running of the tests" you describe.