Skip to content

-act #562 Remove ClassBehavior as we're betting on Actorable #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2020
Merged

-act #562 Remove ClassBehavior as we're betting on Actorable #581

merged 2 commits into from
Apr 27, 2020

Conversation

@ktoso
Copy link
Member

@ktoso ktoso commented Apr 26, 2020

Remove ClassBehaviors

Motivation:

  • we now have Actorables if people want to use "class style"
  • people can still ofc put a behavior in a class if they wanted to, tho it's tricky to get right.

Modifications:

  • remove all traces of ClassBehavior

Result:

@ktoso
Copy link
Member Author

ktoso commented Apr 26, 2020

Failure was #556 putting into my monday-bugfix-list

yim-lee
yim-lee approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@ktoso ktoso merged commit 5fdd1d5 into apple:master Apr 27, 2020
@ktoso ktoso deleted the wip-remove-class-behavior branch April 27, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yim-lee yim-lee yim-lee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Actorable vs. ClassBehavior: should the later be removed?

2 participants

@ktoso @yim-lee