Add Xcc flags that fixes crash on ESP32-C3.
#20
Conversation
This fixes apple#15, making the `smart-light` example run on ESP32-C3. I'm don't have enough knowledge to know if this is the proper fix/correct location to add these flags, but it makes the example work for me at least.
There was a problem hiding this comment.
hi @cheif, firstly thank you for the PR. I think we would like to take a slightly different approach to supporting the C3, please take a look at this recent PR to embedded examples for reference: apple/swift-embedded-examples@ab9a24c
|
Thanks for the feedback @rauhul! I've now update the PR to use a similar pattern as in the linked PR. Unfortunately I don't have access to any other ESP32 devices than the ESP32-C3, so I can't really test with other chips, but I've verified that it works on my ESP32-C3 at least. |
|
Try this pull request with |
|
I was out sick for the last couple weeks 😬, this diff looks good to me, @kubamracek can you also confirm before we merge this? |
|
LGTM. Do we also have a confirmation that the result actually works fully on a C3, and that it can connect to HomeKit and the smart light can be controlled? If yes, I would we would also want to update the README(s) to state that. |
This fixes #15, making the
smart-lightexample run on ESP32-C3.I'm don't have enough knowledge to know if this is the proper fix/correct location to add these flags, but it makes the example work for me at least.