Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we need to fflush(stdout) in the DebugInbound/OutboundEventsHandlers #121

Closed
weissi opened this issue Mar 4, 2021 · 1 comment
Closed

we need to fflush(stdout) in the DebugInbound/OutboundEventsHandlers #121

weissi opened this issue Mar 4, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@weissi
Copy link
Member

weissi commented Mar 4, 2021

swift-nio-extras/Sources/NIOExtras/DebugInboundEventsHandler.swift

Line 109 in de1c80a

print(message + " in \(context.name)")

This print will only happen once stdio flushes the stdout buffer. On a terminal that'll be immediately (usually, because line buffered) but in production, you're likely writing to a pipe and then stdout is fully buffered, ie. you'll only see these prints much later.

What we need after the print is a flush(stdout) to flush it straight away.
@weissi weissi added the good first issue Good for newcomers label Mar 4, 2021
@NicolasCombe5555 NicolasCombe5555 mentioned this issue Aug 27, 2021
Merged
NicolasCombe5555 added a commit to NicolasCombe5555/swift-nio-extras that referenced this issue Aug 27, 2021
@NicolasCombe5555
Add fflush(stdout) to DebugInboundEventsHandler and DebugOutboundEv…
ff2dcf2 
…entsHandler (apple#121)
@glbrntt
Copy link
Contributor

glbrntt commented Sep 2, 2021

Resolved by #140

@glbrntt glbrntt closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weissi @glbrntt