Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly notify StreamMultiplexer of SETTINGS changes. #67

Merged

Conversation

Projects
None yet
2 participants
@Lukasa
Copy link
Contributor

commented Mar 15, 2019

Motivation:

The StreamMultiplexer and StreamChannels are responsible for sending
WINDOW_UPDATE frames, but they were never told if the user changed the
value of SETTINGS_INITIAL_WINDOW_SIZE. They should be.

Modifications:

  • Send user events when SETTINGS_INITIAL_WINDOW_SIZE changes.
  • Use those window events to change the target window size in
    HTTP2StreamChannel.
  • Keep track of the last stream window size we knew.

Result:

Less chance of flow control mess.

Correctly notify StreamMultiplexer of SETTINGS changes.
Motivation:

The StreamMultiplexer and StreamChannels are responsible for sending
WINDOW_UPDATE frames, but they were never told if the user changed the
value of SETTINGS_INITIAL_WINDOW_SIZE. They should be.

Modifications:

- Send user events when SETTINGS_INITIAL_WINDOW_SIZE changes.
- Use those window events to change the target window size in
    HTTP2StreamChannel.
- Keep track of the last stream window size we knew.

Result:

Less chance of flow control mess.

@Lukasa Lukasa requested a review from weissi Mar 15, 2019

@weissi

weissi approved these changes Mar 15, 2019

Copy link
Member

left a comment

👍

@Lukasa Lukasa merged commit 55daa4c into apple:master Mar 15, 2019

1 check passed

pull request validation (5.0) Build finished.
Details

@Lukasa Lukasa deleted the Lukasa:cb-notify-flow-control-changes-on-settings-ack branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.