Use CInt and CUnsignedInt when calling C APIs #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: On different platforms C may define `int` and `unsigned` to be different types. When writing C interop code in Swift it's preferable to use the `CInt` and `CUnsignedInt` typealiases as they will resolve to the correct C type on all supported platforms. If the imported C API is a definite-sized type, like `uint32_t` we leave the Swift type as definitely-sized. Modifications: Use `CInt` instead of `Int32` for C `int` parameters and `CUnsignedInt` instead of `UInt32` for C `unsigned` parameters. Result: Code is more portable and definite-sized types stand out.
Lukasa
added
the
patch-version-bump-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On different platforms C may define
intandunsignedto be differenttypes. When writing C interop code in Swift it's preferable to
use the
CIntandCUnsignedInttypealiases as they will resolve tothe correct C type on all supported platforms. If the imported C API is
a definite-sized type, like
uint32_twe leave the Swift type asdefinitely-sized.
Modifications:
Use
CIntinstead ofInt32for Cintparameters andCUnsignedIntinstead of
UInt32for Cunsignedparameters.Result:
Code is more portable and definite-sized types stand out.