Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mutating in MessageToByteEncoder encode #1580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow mutating in MessageToByteEncoder encode #1580

wants to merge 1 commit into from

Conversation

Davidde94
Copy link
Contributor

Resolves #1579

Structs are now able to conform and track a state where mutating is required.

@Davidde94 Davidde94 added the 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Jun 29, 2020
@Davidde94 Davidde94 modified the milestones: 2.19.0, 3.0.0 Jun 29, 2020
@Davidde94 Davidde94 added ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 and removed 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 labels Jun 29, 2020
@Davidde94 Davidde94 changed the title Allow mutating in ByteToMessageDecoder encode Allow mutating in MessageToByteEncoder encode Jun 29, 2020
@glbrntt glbrntt removed the request for review from weissi June 29, 2020 12:02
Copy link
Contributor

@PeterAdams-A PeterAdams-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the tests pass which isn't a great sign. It can't go in at the moment just to sem-ver major anyway.

@Lukasa Lukasa changed the base branch from master to main September 24, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageToByteEncoder doesn't allow mutating conformance
2 participants