Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track down the two extra allocations in Swift 5 #726

Closed
weissi opened this issue Jan 2, 2019 · 0 comments · Fixed by #780
Closed

track down the two extra allocations in Swift 5 #726

weissi opened this issue Jan 2, 2019 · 0 comments · Fixed by #780
Assignees
@weissi
Labels
task Something which is not a defect needs to be done.
Milestone
2.0.0

Comments

@weissi
Copy link
Member

weissi commented Jan 2, 2019

in #725 I had to raise the allocation limits for Swift 5 because there's a regression in Swift 5. We need to track down the problem in Swift and then hopefully lower them again.
@weissi weissi mentioned this issue Jan 2, 2019
Merged
@weissi weissi self-assigned this Jan 2, 2019
@weissi weissi added this to the 2.0.0 milestone Jan 2, 2019
@weissi weissi added the task Something which is not a defect needs to be done. label Jan 2, 2019
@weissi weissi mentioned this issue Jan 2, 2019
Merged
@weissi weissi mentioned this issue Jan 25, 2019
Merged
weissi added a commit that referenced this issue Jan 25, 2019
@weissi
CI: use DEVELOPMENT-SNAPSHOT-2019-01-23-a (#780)
58a58b9 
Motivation:

Newer Swift versions are good and we should test them, this one threw a few curveballs at us:
- started using `posix_memalign` which needed fixing in our alloc tests (fixed in #782)
- the optimiser decided not to inline a function that needs to be inlined

Modifications
- `@inline(__always)` to help the optimiser
- update Swift version

Result:
- fixes #727
- fixes #726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weissi weissi

Labels
task Something which is not a defect needs to be done.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

CI: use DEVELOPMENT-SNAPSHOT-2019-01-23-a weissi/swift-nio
1 participant
@weissi