Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcceptHandler: don't swallow close errors when quiescing #1015

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented May 22, 2019

Motivation:

When receiving the ChannelShouldQuiesceEvent event, the AcceptHandler
correctly closes the ServerChannel. However, if that fails, it swallows
the error which is incorrect.

Modifications:

Don't swallow the error, send it through the pipeline.

Result:

More correct.

@weissi weissi requested a review from Lukasa May 22, 2019

@Lukasa Lukasa added this to the 2.2.0 milestone May 22, 2019

@weissi weissi force-pushed the weissi:jw-accept-dont-swallow-error branch from 6937ae0 to 5554bcd May 22, 2019

@Lukasa

Lukasa approved these changes May 22, 2019

AcceptHandler: don't swallow close errors when quiescing
Motivation:

When receiving the ChannelShouldQuiesceEvent event, the AcceptHandler
correctly closes the ServerChannel. However, if that fails, it swallows
the error which is incorrect.

Modifications:

Don't swallow the error, send it through the pipeline.

Result:

More correct.

@weissi weissi force-pushed the weissi:jw-accept-dont-swallow-error branch from 5554bcd to f13a240 May 22, 2019

@Lukasa Lukasa modified the milestones: 2.2.0, 2.3.0 May 22, 2019

@Lukasa Lukasa merged commit ca92786 into apple:master May 24, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.