Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_no_api_breakages, a script to check public API breakages #1016

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
3 participants
@weissi
Copy link
Member

commented May 23, 2019

Motivation:

It's incredibly hard not to accidentally break the public API, so let's
automate that :).

Modifications:

Add the first version of a public API check script.

Result:

Fewer public API breakages.

Add check_no_api_breakages, a script to check public API breakages
Motivation:

It's incredibly hard not to accidentally break the public API, so let's
automate that :).

Modifications:

Add the first version of a public API check script.

Result:

Fewer public API breakages.

@weissi weissi requested a review from Lukasa May 23, 2019

git checkout "$tag" 2> /dev/null
swift build
while read -r module; do
swift api-digester -dump-sdk -module "$module" \

This comment has been minimized.

Copy link
@ktoso

ktoso May 23, 2019

Member

Wohoo 🥳

@Lukasa Lukasa added this to the 2.3.0 milestone May 23, 2019

@Lukasa

Lukasa approved these changes May 23, 2019

@Lukasa Lukasa merged commit 0357118 into apple:master May 23, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.