Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc counters: disallow too high limits #1022

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented May 30, 2019

Motivation:

For the allocation counter tests to be as useful as possible, we should
disallow limits that are too high, we should capture the allocation
count very close to where it actually is.

Modifications:

Don't allow any allocation counter test to allocate fewer than
'limit - 1000' allocations.

Result:

Better limits.

@@ -37,21 +37,6 @@ func run(identifier: String) {
}
@inline(never)
func doReads(buffer: inout ByteBuffer) {
/* these ones are zero allocations */

This comment has been minimized.

Copy link
@weissi

weissi May 30, 2019

Author Member

this will go away, just to temporarily test this PR actually works :)

@Lukasa Lukasa added this to the 2.3.0 milestone May 30, 2019

@weissi weissi force-pushed the weissi:jw-disallow-underest branch 2 times, most recently from 4c92f79 to c8b0d20 Jun 2, 2019

alloc counters: disallow too high limits
Motivation:

For the allocation counter tests to be as useful as possible, we should
disallow limits that are too high, we should capture the allocation
count very close to where it actually is.

Modifications:

Don't allow any allocation counter test to allocate fewer than
'limit - 1000' allocations.

Result:

Better limits.

@weissi weissi force-pushed the weissi:jw-disallow-underest branch from c8b0d20 to 0790500 Jun 2, 2019

@weissi weissi requested a review from Lukasa Jun 2, 2019

@Lukasa

Lukasa approved these changes Jun 2, 2019

@Lukasa Lukasa merged commit 8112653 into apple:master Jun 2, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details

@weissi weissi deleted the weissi:jw-disallow-underest branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.