Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the EndToEndTests for WebSockets. #1032

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@tigerpixel
Copy link
Contributor

commented Jun 11, 2019

Rename the 'EndToEndTests' in the WebSocket project to 'WebSocketServerEndToEndTests'.

Motivation:

To make the web socket server end to end tests class more descriptive.
This will allow ‘WebSocketClientEndToEndTests’ or other end to end tests to be added at a later date.

Modifications:

Renames the class and filename for ‘EndToEndTests’ to ‘WebSocketServerEndToEndTests’

Result:

The nomenclature now allow for other end to end tests to be added.

Rename the EndToEndTests in the WebSocket project to WebSocketServerE…
…ndToEndTests.

Motivation:

To make the web socket server end to end tests class more descriptive.
This will allow ‘WebSocketClientEndToEndTests’ or other end to end tests to be added at a later date.

Modifications:

Renames the class and filename for ‘EndToEndTests’ to ‘WebSocketServerEndToEndTests’

Result:

The nomenclature now allow for other end to end tests to be added.
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

5 similar comments
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Can one of the admins verify this patch?

@Lukasa Lukasa added this to the 2.3.0 milestone Jun 11, 2019

@Lukasa

Lukasa approved these changes Jun 11, 2019

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@swift-nio-bot test this please

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Thanks!

@Lukasa Lukasa merged commit f508435 into apple:master Jun 12, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.