Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove platform availability again #1042

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented Jun 18, 2019

Motivation:

The platform availability that we recently introduced caused problems
because it would require all downstream projects to define the same or
narrower platform availability to still compile with NIO which would
make this very disrupting and also SemVer major.

Modifications:

Remove the platform availability declarations.

Result:

No SemVer breakages.

remove platform availability again
Motivation:

The platform availability that we recently introduced caused problems
because it would require all downstream projects to define the same or
narrower platform availability to still compile with NIO which would
make this very disrupting and also SemVer major.

Modifications:

Remove the platform availability declarations.

Result:

No SemVer breakages.

@weissi weissi requested a review from Lukasa Jun 18, 2019

@weissi weissi added this to the 2.3.0 milestone Jun 18, 2019

@Lukasa

Lukasa approved these changes Jun 18, 2019

@weissi

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

19:00:46 removal of container cdfa48b92d773b046680d7a412b7467632326d3122e5afab5de367c39a052e28 is already in progress
@weissi

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

@swift-nio-bot test this please

@weissi weissi merged commit 7829542 into apple:master Jun 18, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details

@weissi weissi deleted the weissi:jw-rm-platforms branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.