Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPDecoder: no error on unclean EOF on upgrade #1063

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented Jul 11, 2019

Motivation:

Previously we thought that if we have some bytes left that belong to an
upgraded protocol, we should deliver those as an error. This is
implemented on master but not in any released NIO version.
However, no other handler sends errors on unclean shutdown, so it feels
wrong to do it in this one very specific case (EOF on inflight upgrade
with data for the upgraded protocol)

Modifications:

Remove the error again.

Result:

Less behaviour change to the last released NIO version.

HTTPDecoder: no error on unclean EOF on upgrade
Motivation:

Previously we thought that if we have some bytes left that belong to an
upgraded protocol, we should deliver those as an error. This is
implemented on `master` but not in any released NIO version.
However, no other handler sends errors on unclean shutdown, so it feels
wrong to do it in this one very specific case (EOF on inflight upgrade
with data for the upgraded protocol)

Modifications:

Remove the error again.

Result:

Less behaviour change to the last released NIO version.

@weissi weissi requested a review from Lukasa Jul 11, 2019

@Lukasa Lukasa added this to the 2.4.0 milestone Jul 11, 2019

@Lukasa

Lukasa approved these changes Jul 11, 2019

@Lukasa Lukasa merged commit 334815f into apple:master Jul 11, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details

@weissi weissi deleted the weissi:jw-no-err-on-unclean branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.