Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WebSocket Client example. As Per issue #465 #1064

Merged
merged 6 commits into from Jul 26, 2019

Conversation

@tigerpixel
Copy link
Contributor

commented Jul 12, 2019

Add a WebSocket Client example class to match the WebSocket server example.

Motivation:

To provide an example of the usage of the WebSocket client upgrade functionality.
To satisfy issue #465

Modifications:

Added a ‘WebSocketClient’ example with a readme and a target in the package file.

Result:

There is now a WebSocket client example to assist with the creation of a WebSocket client.

Liam Flynn
Add a WebSocket Client example class to match the WebSocket server ex…
…ample.

Motivation:

To provide an example of the usage of the WebSocket client upgrade functionality.
To satisfy issue #465

Modifications:

Added a ‘WebSocketClient’ example with a readme and a target in the package file.

Result:

There is now a WebSocket client example to assist with the creation of a WebSocket client.
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

5 similar comments
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

Can one of the admins verify this patch?

@weissi

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@swift-nio-bot please test

@weissi

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@swift-nio-bot test this please

@Lukasa Lukasa requested review from Lukasa and weissi Jul 15, 2019

@Lukasa Lukasa added this to the 2.5.0 milestone Jul 15, 2019

@Lukasa
Copy link
Contributor

left a comment

Thanks, this generally looks good! I've left a few notes in the diff.

Sources/NIOWebSocketClient/main.swift Outdated Show resolved Hide resolved
Sources/NIOWebSocketClient/main.swift Outdated Show resolved Hide resolved

@Lukasa Lukasa modified the milestones: 2.5.0, 3.0.0, 2.6.0 Jul 22, 2019

tigerpixel and others added some commits Jul 24, 2019

Liam Flynn
Updated the WebSocket example to use the data within WebSocket frames…
… correctly.

Motivation:

This is a NIO example and so should display correct usage of the buffers.

Modifications:

Changed the way that the buffers are read and written in the ping and pong data functions.

Result:

Correct NIO usage in the example.
@tigerpixel

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Apologies for the delay. Both done.

@weissi weissi requested a review from Lukasa Jul 25, 2019

@Lukasa

Lukasa approved these changes Jul 26, 2019

Copy link
Contributor

left a comment

LGTM, thanks!

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

@swift-nio-bot test this please

@weissi

weissi approved these changes Jul 26, 2019

Copy link
Member

left a comment

Awesome, thanks! LGTM

@weissi weissi merged commit fa2a1fd into apple:master Jul 26, 2019

4 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.