Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api breakage tester: fetch all refs #1076

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@weissi
Copy link
Member

commented Jul 17, 2019

Motivation:

To be able to use SHA sums as git versions, we need to pull all the refs
to we get even the commit SHAs from PRs. That's important so CI can use
this script.

Modifications:

Fetch +refs/pull/*:refs/remotes/origin/pr/* refs.

Result:

Should be able to be usable in CI across forks.

api breakage tester: fetch all refs
Motivation:

To be able to use SHA sums as git versions, we need to pull all the refs
to we get even the commit SHAs from PRs. That's important so CI can use
this script.

Modifications:

Fetch `+refs/pull/*:refs/remotes/origin/pr/*` refs.

Result:

Should be able to be usable in CI across forks.

@weissi weissi requested a review from tomerd Jul 17, 2019

@tomerd

tomerd approved these changes Jul 17, 2019

Copy link
Member

left a comment

thanks

@Lukasa Lukasa added this to the 2.5.0 milestone Jul 17, 2019

@Lukasa

Lukasa approved these changes Jul 17, 2019

@weissi weissi merged commit ca69149 into apple:master Jul 17, 2019

4 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details

@weissi weissi deleted the weissi:jw-fetch-more branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.