Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example links to readme #1087

Merged
merged 3 commits into from Jul 30, 2019

Conversation

@tigerpixel
Copy link
Contributor

commented Jul 30, 2019

Add example links to the project README file.

Motivation:

To give visibility to recently added examples.

Modifications:

Added links to examples in the readme file.
Slightly re-arranged the order so that echo examples are next to each other in the list.

Result:

You can now see the UDP, HTTP and WebSocket client examples from the README file.

Liam Flynn added some commits Jul 30, 2019

Liam Flynn
Update the README file to include some recently added examples.
Motivation:

To give visibility to recently added examples.
To satisfy issue #465

Modifications:

Added links to examples in readme.
Slightly re-arranged the order so that echo examples are next to each other in the list.

Result:

You can now see the UDP, HTTP and WebSocket client examples from the README file.
Liam Flynn
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

8 similar comments
@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@swift-nio-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Can one of the admins verify this patch?

@Lukasa Lukasa added this to the 2.6.0 milestone Jul 30, 2019

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@swift-nio-bot test this please

@Lukasa

Lukasa approved these changes Jul 30, 2019

Copy link
Contributor

left a comment

LGTM, thanks!

@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@swift-nio-bot test this please

@Lukasa Lukasa merged commit 4fa0921 into apple:master Jul 30, 2019

4 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.