Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link to process_test_files.rb in NOTICE.txt #1119

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@ktoso
Copy link
Member

commented Aug 20, 2019

Fix dead link in NOTICE.txt

Motivation:

Previous link is dead, so we might want to point to a specific commit that introduced what our scripts are based on.

Modifications:

  • add new links to same authors script

Result:

  • up to date and more "future-proof" links in NOTICE
Fix dead link to process_test_files.rb in NOTICE.txt
Previous link is dead, so we might want to point to a specific commit that introduced what our scripts are based on.

@Lukasa Lukasa added this to the 2.7.0 milestone Aug 20, 2019

@ktoso

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

Ah, and thanks to @normanmaurer for the detective work 🕵

@Lukasa Lukasa modified the milestones: 2.7.0, 2.8.0 Aug 20, 2019

@Lukasa
Lukasa approved these changes Aug 20, 2019
@Lukasa

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thanks @ktoso!

@weissi
weissi approved these changes Aug 20, 2019
Copy link
Member

left a comment

thank you!

@weissi weissi merged commit 0c75974 into apple:master Aug 20, 2019

4 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details

@ktoso ktoso deleted the ktoso:patch-3 branch Aug 20, 2019

@weissi weissi modified the milestones: 2.8.0, 2.7.1 Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.