Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear generate_linux_tests must be run #113

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
5 participants
@helje5
Copy link
Contributor

helje5 commented Mar 8, 2018

Motivation:

The path of the script to invoke was wrong,
also highlight that this is absolutely required
for a PR.

Modifications:

Some bold, some text, some proper path.

Result:

CI will be super happy as less people will
fail to generate proper Linux tests.

P.S.: FWIW, if there is a script that works, the CI should probably just run it in the first place.

Make clear generate_linux_tests must be run
Motivation:

The path of the script to invoke was wrong,
also highlight that this is absolutely required
for a PR.

Modifications:

Some bold, some text, some proper path.

Result:

CI will be super happy as less people will
fail to generate proper Linux tests.
@swift-nio-bot

This comment has been minimized.

Copy link

swift-nio-bot commented Mar 8, 2018

Can one of the admins verify this patch?

@tomerd

This comment has been minimized.

Copy link
Member

tomerd commented Mar 8, 2018

@swift-nio-bot test this please

@tomerd

This comment has been minimized.

Copy link
Member

tomerd commented Mar 8, 2018

we should probably also add a pre commit hook in the dev directory. i’ll let @Lukasa review the language change

@Lukasa

Lukasa approved these changes Mar 8, 2018

Copy link
Contributor

Lukasa left a comment

Happy with this, thanks @helje5!

@Lukasa Lukasa merged commit 6b182f4 into apple:master Mar 8, 2018

1 check passed

pull request validation Build finished.
Details

@helje5 helje5 deleted the helje5:bugs/test-doc-bug branch Mar 8, 2018

@normanmaurer
Copy link
Member

normanmaurer left a comment

LGTM

@normanmaurer normanmaurer added this to the 1.2.0 milestone Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.