Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-single-file-spm: support lines ending in `n` #1251

Merged
merged 1 commit into from Nov 18, 2019
Merged

Conversation

@weissi
Copy link
Member

weissi commented Nov 18, 2019

Motivation:

make-single-file-spm has a weird bug where it would chop off trailing
n characters in all lines due to a badly set IFS bash variable.

Modifications:

Set IFS="" which is correct.

Result:

make-single-file-spm will not chop off trailing ns.

Motivation:

make-single-file-spm has a weird bug where it would chop off trailing
`n` characters in all lines due to a badly set `IFS` bash variable.

Modifications:

Set `IFS=""` which is correct.

Result:

make-single-file-spm will not chop off trailing `n`s.
@weissi weissi requested a review from Davidde94 Nov 18, 2019
@weissi weissi merged commit 9dd9f36 into apple:master Nov 18, 2019
4 checks passed
4 checks passed
pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
@weissi weissi deleted the weissi:jw-sf branch Nov 18, 2019
@weissi weissi added this to the 2.11.0 milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.