Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example binaries from products #1303

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@johnlinvc
Copy link
Contributor

johnlinvc commented Dec 12, 2019

Motivation:

Avoid examples being build when using as library.
Address #1217

Modifications:

Remove example binaries from products.
Update example section in README, show how to run them.

Result:

Examples are not being built when running swift build

Motivation:

Avoid examples being build when using as library.
Address #1217

Modifications:

Remove example binaries from products.
Update example section in README, show how to run them.

Result:

Examples are not being built when running `swift build`
@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

8 similar comments
@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@swift-server-bot

This comment has been minimized.

Copy link

swift-server-bot commented Dec 12, 2019

Can one of the admins verify this patch?

@Lukasa Lukasa requested a review from weissi Dec 12, 2019
@Lukasa

This comment has been minimized.

Copy link
Contributor

Lukasa commented Dec 12, 2019

@weissi how do we want to rate the semver impact of this?

@Lukasa Lukasa added this to the 2.12.0 milestone Dec 12, 2019
@Lukasa
Lukasa approved these changes Dec 12, 2019
Copy link
Contributor

Lukasa left a comment

LGTM, thanks!

@Lukasa

This comment has been minimized.

Copy link
Contributor

Lukasa commented Dec 12, 2019

@swift-nio-bot test this please

@weissi

This comment has been minimized.

Copy link
Member

weissi commented Dec 12, 2019

@Lukasa let's do minor :)

@weissi
weissi approved these changes Dec 12, 2019
Copy link
Member

weissi left a comment

thank you, lgtm!

@Lukasa Lukasa merged commit 9ec23f5 into apple:master Dec 12, 2019
4 checks passed
4 checks passed
pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.