Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documenation in HTTPHeaders. #1335

Merged
merged 1 commit into from Jan 11, 2020
Merged

Conversation

@glbrntt
Copy link
Contributor

glbrntt commented Jan 10, 2020

Motivation:

subscript(name:) and first(name:) incorrectly referred users to
getCanonicalForm for a maximally decomposed list of header fields.
This no longer exists.

Modifications:

Point users to subscript(canonicalForm:).

Result:

More accurate documentation.

Motivation:

`subscript(name:)` and `first(name:)` incorrectly referred users to
`getCanonicalForm` for a maximally decomposed list of header fields.
This no longer exists.

Modifications:

Point users to `subscript(canonicalForm:)`.

Result:

More accurate documenation.
@glbrntt glbrntt requested a review from Lukasa Jan 10, 2020
@Lukasa Lukasa added this to the 2.13.0 milestone Jan 10, 2020
@Lukasa
Lukasa approved these changes Jan 10, 2020
@weissi
weissi approved these changes Jan 11, 2020
Copy link
Member

weissi left a comment

oops ;). Thank you!!

@weissi weissi merged commit f44fe0b into apple:master Jan 11, 2020
4 checks passed
4 checks passed
pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
@glbrntt glbrntt deleted the glbrntt:gb-fixup-httpheader-docs branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.