Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stackdiff-ing in the debugging-allocations doc #1384

Merged
merged 3 commits into from Feb 6, 2020

Conversation

@glbrntt
Copy link
Contributor

glbrntt commented Feb 5, 2020

Motivation:

We recently grew a script to diff the output of malloc-aggregation.d,
we should document how this can be used when debugging allocation
regressions.

Modifications:

  • Update the doc to include an example of using the script to debug an
    allocation regression
  • Fix a bug in the script where before/after were mixed up
  • Fix a bug in the script where usage would print '()\n' instead of '\n'

Result:

  • Better info on debugging allocations
Motivation:

We recently grew a script to diff the output of `malloc-aggregation.d`,
we should document how this can be used when debugging allocation
regressions.

Modifications:

- Update the doc to include an example of using the script to debug an
  allocation regression
- Fix a bug in the script where before/after were mixed up
- Fix a bug in the script where usage would print '()\n' instead of '\n'

Result:

- Better info on debugging allocations
@glbrntt glbrntt requested a review from weissi Feb 5, 2020
@weissi
weissi approved these changes Feb 5, 2020
Copy link
Member

weissi left a comment

Thanks so much, that's awesome!!

@weissi weissi added this to the 2.14.0 milestone Feb 5, 2020
@weissi weissi merged commit ddb7109 into apple:master Feb 6, 2020
4 of 5 checks passed
4 of 5 checks passed
pull request validation (5.1) Build finished.
Details
pull request validation (5.0) Build finished.
Details
pull request validation (5.2) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.