Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pod updater script #1391

Merged
merged 1 commit into from Feb 13, 2020
Merged

improve pod updater script #1391

merged 1 commit into from Feb 13, 2020

Conversation

@weissi
Copy link
Member

weissi commented Feb 12, 2020

Motivation:

Somewhere in github or Cocoapods, there seems to be a problem that if
you push a pod A and quickly after a pod B that depends on A with
exactly the version you just pushed, the validation sometimes fails
claiming that the right version of A is not available. The workaround is
to wait a bit and to call pod repo update.
The modifications in this PR alleviate this problem somewhat, it now
calls pod repo update by itself and should it still go wrong, there's
a new -f (from) option that can be used to skip over all pods until
the one that failed last. Example

scripts/build_podspecs.sh -u -f SwiftNIO 2.13.1

Modifications:

  • update the pod repo often
  • provide a skipping option to skip over earlier repos in case something
    still goes wrong

Result:

Easier way to update the pods.

Johannes Weiss
Motivation:

Somewhere in github or Cocoapods, there seems to be a problem that if
you push a pod A and quickly after a pod B that depends on A with
exactly the version you just pushed, the validation sometimes fails
claiming that the right version of A is not available. The workaround is
to wait a bit and to call `pod repo update`.
The modifications in this PR alleviate this problem somewhat, it now
calls `pod repo update` by itself and should it still go wrong, there's
a new `-f` (from) option that can be used to skip over all pods until
the one that failed last. Example

    scripts/build_podspecs.sh -u -f SwiftNIO 2.13.1

Modifications:

- update the pod repo often
- provide a skipping option to skip over earlier repos in case something
  still goes wrong

Result:

Easier way to update the pods.
@weissi weissi requested a review from Lukasa Feb 12, 2020
@Lukasa
Lukasa approved these changes Feb 13, 2020
@Lukasa Lukasa added this to the 2.14.0 milestone Feb 13, 2020
@Lukasa Lukasa merged commit 589bc7c into apple:master Feb 13, 2020
5 checks passed
5 checks passed
pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (5.2) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.