Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AcceptHandler after serverChannelInitializer runs #1393

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@weissi
Copy link
Member

weissi commented Feb 13, 2020

Motivation:

For compatibility with 2.13.1 and earlier, we're adding the
AcceptHandler after the serverChannelInitializer runs. If that's the
best solution is discussed in #1392.

Modifications:

  • add AcceptHandler after the serverChannelInitializer
  • give the AcceptHandler the name AcceptHandler

Result:

  • better compatibility
@weissi weissi requested a review from Lukasa Feb 13, 2020
@Lukasa Lukasa added this to the 2.14.0 milestone Feb 13, 2020
@Lukasa
Lukasa approved these changes Feb 13, 2020
Copy link
Contributor

Lukasa left a comment

LGTM, good find, thanks!

Motivation:

For compatibility with 2.13.1 and earlier, we're adding the
AcceptHandler after the serverChannelInitializer runs. If that's the
best solution is discussed in #1392.

Modifications:

- add AcceptHandler after the serverChannelInitializer
- give the AcceptHandler the name AcceptHandler

Result:

- better compatibility
@weissi weissi force-pushed the weissi:jw-accept-after-init branch from 0da8462 to 892fbed Feb 13, 2020
@weissi weissi merged commit 16ab4d6 into apple:master Feb 13, 2020
5 checks passed
5 checks passed
pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
pull request validation (5.2) Build finished.
Details
pull request validation (api breakage) Build finished.
Details
pull request validation (sanity) Build finished.
Details
@weissi weissi deleted the weissi:jw-accept-after-init branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.