CircularBuffer: use vendored swift-collections/Deque instead #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Less (SwiftNIO maintained) code is better and Swift Collection's got an excellent Deque implementation that NIO should just use. Modification: Use Swift Collection's Deque to back CircularBuffer instead rolling our own (which is certainly much slower). Result: - Less (NIO maintained) code - faster
|
@swift-nio-bot test perf please |
Lukasa
reviewed
Apr 6, 2021
| @@ -0,0 +1,23 @@ | |||
| /* Changes for SwiftNIO | |||
| - renamed NIODeque to NIONIODeque (to prevent future clashes) | |||
| - made (NIO)NIODeque internal (not public) | |||
There was a problem hiding this comment.
Something here is prefixing NIO again.
|
Oh, awesome :-) |
Except that it doesn’t work 😂😂. https://forums.swift.org/t/rfc-deque-should-it-have-an-opaque-index/47203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Less (SwiftNIO maintained) code is better and Swift Collection's got an
excellent Deque implementation that NIO should just use.
Modification:
Use Swift Collection's Deque to back CircularBuffer instead rolling our
own (which is certainly much slower).
Result: