ByteBuffer: provide multi read/write int methods #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated code (10 UInt32s) looks pretty awesome, lots of vector stuff haha.
|
|
@swift-nio-bot perf test this please |
|
@Lukasa we should probably make this |
glbrntt
reviewed
Nov 19, 2021
|
@swift-nio-bot test perf please |
|
@swift-nio-bot test perf please |
weissi
commented
Nov 19, 2021
performance reportbuild id: 83 timestamp: Fri Nov 19 11:01:40 UTC 2021 results
comparison
significant differences found |
|
here's the perf proof:
|
performance reportbuild id: 84 timestamp: Fri Nov 19 11:04:53 UTC 2021 results
comparison
significant differences found |
|
Nice, this will unlock some nice perf gains in postgres :) |
weissi
force-pushed
the
jw-multi-rw
branch
2 times, most recently
from
bb5d09a
to
5a5c76d
Compare
Lukasa
reviewed
Nov 22, 2021
Motivation: Many network protocols (especially for example NFS) have quite a number of integer values next to each other. In NIO, you'd normally parse/write them with multiple read/writeInteger calls. Unfortunately, that's a bit wasteful because we're checking the bounds as well as the CoW state every time. Modifications: - Provide read/writeMultipleIntegers for up to 15 FixedWidthIntegers. - Benchmarks Result: Faster code. For 10 UInt32s, this is a 5x performance win on my machine, see benchmarks.
Lukasa
approved these changes
Nov 22, 2021
dnadoba
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
LGTM. A good example for what we might use TypeSequences aka Variadic Generics if we get the same performance out of it. Maybe worth posting this use case on the pitch thread.
We could, however the variadics would only really if the types are all the same. Ie |
|
@weissi Not sure I can follow you here, the pitch for TypeSequences contains this code example: func debugPrint<T...>(_ items: T...)
where T: CustomDebugStringConvertible
{
for (item: T) in items {
stdout.write(item.debugDescription)
}
}If I read this correctly, the new script generated code could be implemented as this, couldn't it? func readMultipleIntegers<T...>(endianness: Endianness = .big, as types: T.Type...)
where T: FixedWidthInteger
{
// implementation
} |
Thank you! yes, I missed the ellipsis in the generic arguments. That's cool if this would be supported, very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Many network protocols (especially for example NFS) have quite a number
of integer values next to each other. In NIO, you'd normally parse/write
them with multiple read/writeInteger calls.
Unfortunately, that's a bit wasteful because we're checking the bounds
as well as the CoW state every time.
Modifications:
Result:
Faster code. For 10 UInt32s, this is a 5x performance win on my machine,
see benchmarks.