Suppress the performance checker warning by being sneaky #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users are receiving thread performance checker warnings when they create MTELGs. This is largely unnecessary: MTELGs are not typically created on the fly but instead once, at program startup. That means the issue here isn't really all that profound. While we could work around it by substantially rearchitecting the event loops (see apple#2618), an easier fix is to observe that the thread performance checker doesn't fire when we use condition variables. Modifications: Remove the use of the DispatchGroup and replace it with a condition variable. Result: Simpler code and no thread performance checker warning.
FranzBusch
approved these changes
Jan 5, 2024
rebello95
added a commit
to connectrpc/connect-swift
that referenced
this pull request
Jan 31, 2024
Updates our NIO dependencies to include https://github.com/apple/swift-nio/releases/tag/2.63.0 which fixes a performance checker warning seen when instantiating the NIO client from the main thread: apple/swift-nio#2620. Resolves #181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users are receiving thread performance checker warnings when they create MTELGs. This is largely unnecessary: MTELGs are not typically created on the fly but instead once, at program startup. That means the issue here isn't really all that profound.
While we could work around it by substantially rearchitecting the event loops (see #2618), an easier fix is to observe that the thread performance checker doesn't fire when we use condition variables.
Modifications:
Remove the use of the DispatchGroup and replace it with a condition variable.
Result:
Simpler code and no thread performance checker warning.
Replaces #2618.
Resolves #2223.