Allow ChannelCore implementors to unwrap NIOAny. #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Apr 17, 2018
Sources/NIO/NIOAny.swift
Outdated
| /// Try unwrapping the wrapped message as `ByteBuffer`. | ||
| /// | ||
| /// returns: The wrapped `ByteBuffer` or `nil` if the wrapped message is not a `ByteBuffer`. | ||
| @_versioned |
Contributor
Author
There was a problem hiding this comment.
The current reason is that storage is private. Do we think that's worth changing?
Member
There was a problem hiding this comment.
@Lukasa not for this particular one but possibly for the ones that take generics.
Contributor
Author
There was a problem hiding this comment.
Yeah, I'm a bit on the fence here. I suppose making the storage internal won't be too big a deal.
Member
There was a problem hiding this comment.
me too tbh. I'll make it your call. If you make the storage internal, please underscore it
Contributor
Author
There was a problem hiding this comment.
Ok, made all of these @_inlineable.
Lukasa
force-pushed
the
cb-channelcore-unwrap-nioany
branch
from
320c382 to
b5f9d06
Compare
normanmaurer
requested changes
Apr 17, 2018
Sources/NIO/Channel.swift
Outdated
| } | ||
|
|
||
| public extension ChannelCore { | ||
| /// Unwraps the given NIOAny as a specific concrete type. |
Motivation: When implementing a custom ChannelCore, you will probably need access to the data inside a NIOAny. It should be possible to unwrap that. Modifications: Added an extension to ChannelCore to allow unwrapping a NIOAny. Added @_versioned to almost all of NIOAny. Result: ChannelCore is implementable outside NIO
Lukasa
force-pushed
the
cb-channelcore-unwrap-nioany
branch
from
b5f9d06 to
5b11619
Compare
normanmaurer
approved these changes
Apr 17, 2018
Member
|
test failure should be addressed by #326 |
Member
|
@swift-nio-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When implementing a custom ChannelCore, you will probably need access
to the data inside a NIOAny. It should be possible to unwrap that.
Modifications:
Added an extension to ChannelCore to allow unwrapping a NIOAny.
Added @_versioned to almost all of NIOAny.
Result:
ChannelCore is implementable outside NIO