Make all members of HTTP{Request|Response}Head mutable. #324
Conversation
updates
merge master
Motivation:
Immutable members of structs (properties defined with let) can never be changed
even if the struct itself is mutable (defined withh var). This makes it difficult
to build rich convenience APIs on top of these structs.
Modifications:
Changed all 'let' stored properties on HTTP{Request|Response}Head to 'var'.
Result:
HTTP{Request|Response}Head are easier to use now.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This seems reasonable to me.
|
@swift-nio-bot add to whitelist |
|
|
||
| // Internal representation of the URI. | ||
| private let rawURI: URI | ||
| private var rawURI: URI |
There was a problem hiding this comment.
This one is private so I think this makes no sense or I am missing something ?
There was a problem hiding this comment.
Yeah, that one could stay let.
There was a problem hiding this comment.
I missed adding a set case to uri, that is added now (and relies on rawURI being mutable)
Sources/NIOHTTP1/HTTPTypes.swift
Outdated
| /// The URI used on this request. | ||
| public var uri: String { | ||
| return String(uri: rawURI) | ||
| get { return String(uri: rawURI) } |
There was a problem hiding this comment.
we don't usually skip the newlines here but I don't mind. CC @normanmaurer / @Lukasa
There was a problem hiding this comment.
I would prefer to add them just to make things consistent .
There was a problem hiding this comment.
Consistency is king
|
@swift-nio-bot test this please |
|
@tanner0101 thanks! |
5 participants
Make all members of HTTP{Request|Response}Head mutable.
Motivation:
Immutable members of structs (properties defined with let) can never be changed
even if the struct itself is mutable (defined withh var). This makes it difficult
to build rich convenience APIs on top of these structs.
Modifications:
Changed all 'let' stored properties on HTTP{Request|Response}Head to 'var'.
Result:
HTTP{Request|Response}Head are easier to use now.