New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename numThreads to numberOfThreads parameter. #443

Merged
merged 1 commit into from May 25, 2018

Conversation

@normanmaurer
Copy link
Member

normanmaurer commented May 24, 2018

Motivation:

We should be consistent with naming and also choose descriptive names.

Modifications:

  • Deprecate old init method that uses numThreads
  • Add new init with numberOfThreads param name
  • Everywhere use the new init

Result:

More consistent and descriptive naming. Fixes #432.

@normanmaurer normanmaurer self-assigned this May 24, 2018

@normanmaurer normanmaurer requested review from Lukasa and weissi and removed request for Lukasa May 24, 2018

@normanmaurer normanmaurer added this to the 1.8.0 milestone May 24, 2018

@weissi

weissi approved these changes May 24, 2018

Copy link
Contributor

weissi left a comment

Nice, 👍👍

@weissi weissi requested a review from Lukasa May 24, 2018

/// Creates a `MultiThreadedEventLoopGroup` instance which uses `numberOfThreads`.
///
/// - arguments:
/// - numThreads: The number of `Threads` to use.

This comment has been minimized.

@BasThomas

BasThomas May 25, 2018

Contributor

This should be numberOfThreads, not numThreads.

/// Creates a `MultiThreadedEventLoopGroup` instance which uses `numThreads`.
///
/// - arguments:
/// - numThreads: The number of `Threads` to use.
@available(*, deprecated, renamed: "numberOfThreads")

This comment has been minimized.

@Lukasa

Lukasa May 25, 2018

Contributor

Strictly this was renamed init(numberOfThreads:).

@Lukasa

Lukasa approved these changes May 25, 2018

Copy link
Contributor

Lukasa left a comment

LGTM.

Rename numThreads to numberOfThreads parameter.
Motivation:

We should be consistent with naming and also choose descriptive names.

Modifications:

- Deprecate old init method that uses numThreads
- Add new init with numberOfThreads param name
- Everywhere use the new init

Result:

More consistent and descriptive naming. Fixes #432.

@normanmaurer normanmaurer force-pushed the normanmaurer:rename_init_param branch from 2e369f0 to e9c2cc8 May 25, 2018

@normanmaurer normanmaurer merged commit 82a6e4d into apple:master May 25, 2018

2 checks passed

pull request validation (4.0.3) Build finished.
Details
pull request validation (4.1) Build finished.
Details

@normanmaurer normanmaurer deleted the normanmaurer:rename_init_param branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment