New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more time to close fds in integration tests #611

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@weissi
Contributor

weissi commented Sep 11, 2018

Motivation:

As #563 shows, sometimes in CI we don't reach the number of open
expected file descriptors. The current assumption is that this is just a
race when CI is slow. This allows up to 10s to reach the correct number
of open file descriptors.

Modifications:

  • allow up to 10s to reach the correct number of fds

Result:

hopefully fixing #563 finally

allow more time to close fds in integration tests
Motivation:

As #563 shows, sometimes in CI we don't reach the number of open
expected file descriptors. The current assumption is that this is just a
race when CI is slow. This allows up to 10s to reach the correct number
of open file descriptors.

Modifications:

- allow up to 10s to reach the correct number of fds

Result:

hopefully fixing #563 finally
@Lukasa

Lukasa approved these changes Sep 11, 2018

@Lukasa Lukasa added this to the 1.10.0 milestone Sep 11, 2018

@Lukasa Lukasa merged commit 1ac6090 into apple:master Sep 11, 2018

3 checks passed

pull request validation (4.0.3) Build finished.
Details
pull request validation (4.1) Build finished.
Details
pull request validation (4.2) Build finished.
Details

@weissi weissi deleted the weissi:jw-allow-time-for-fds branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment