New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the allocation limits for Swift 4.2 the main ones #621

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@weissi
Contributor

weissi commented Sep 20, 2018

Motivation:

We always care most about the latest released Swift version. Therefore I
added allocation limits for Swift 4.2 and indicated that the old ones
can be removed as soon as they change.

Modifications:

  • added allocation limits for Swift 4.2
  • added a comment to the old ones that they don't need to be changed
    anymore now

Result:

  • best support for best version
  • document that Swift 4.2 is awesome, lots fewer allocations!
make the allocation limits for Swift 4.2 the main ones
Motivation:

We always care most about the latest released Swift version. Therefore I
added allocation limits for Swift 4.2 and indicated that the old ones
can be removed as soon as they change.

Modifications:

- added allocation limits for Swift 4.2
- added a comment to the old ones that they don't need to be changed
  anymore now

Result:

- best support for best version
- document that Swift 4.2 is awesome, lots fewer allocations!

@weissi weissi requested a review from tomerd Sep 20, 2018

@@ -15,9 +15,21 @@ services:
integration-tests:
image: swift-nio:18.04-4.2
environment:
- MAX_ALLOCS_ALLOWED_1000_reqs_1_conn=36750

This comment has been minimized.

@weissi

weissi Sep 20, 2018

Contributor

CC @eeckstein, @gottesmm, @airspeedswift, @milseman (random list of people CC'd that I know helped reducing these limits) the NIO team say thanks for this: Check this out:

test allocations in 4.1 allocations in 4.2
1000 HTTP/1.1 requests over 1 connection 47 allocations per request/response pair 36 allocs for req/res pair
1 HTTP/1.1 request per connection with 1000 connections 719 allocs per req/res pair 698 allocs

Also CC @tanner0101 / @LoganWright and @ianpartridge / @pushkarnk who'll be happy to know we're down 20% of the allocations (from 47 to 36) to for a HTTP/1.1 request response pair, that's pretty major for 0 NIO code change. And wait for Swift 5.0 💛

This comment has been minimized.

@normanmaurer

normanmaurer Sep 20, 2018

Member

wow... thats really a lot!

This comment has been minimized.

@weissi

weissi Sep 20, 2018

Contributor

I know right!

This comment has been minimized.

@weissi

weissi Sep 20, 2018

Contributor

🍻 for the Swift team!!

This comment has been minimized.

@Lukasa

Lukasa Sep 20, 2018

Contributor

🎉🎉🎉

@weissi weissi added this to the 1.10.0 milestone Sep 20, 2018

@Lukasa

Lukasa approved these changes Sep 20, 2018

@Lukasa Lukasa merged commit 79267e8 into apple:master Sep 20, 2018

3 checks passed

pull request validation (4.0.3) Build finished.
Details
pull request validation (4.1) Build finished.
Details
pull request validation (4.2) Build finished.
Details

@weissi weissi deleted the weissi:jw-beers-for-swift-team branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment