New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributors file #668

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@weissi
Contributor

weissi commented Nov 27, 2018

Motivation:

Now, shortly before 2.0 is a good time to update the contributors list.

Modifications:

Ran the contributor generation script (ASCII'd my name)

Result:

All contributors get their proper credit.

update contributors file
Motivation:

Now, shortly before 2.0 is a good time to update the contributors list.

Modifications:

Ran the contributor generation script (ASCII'd my name)

Result:

All contributors get their proper credit.

@weissi weissi requested a review from Lukasa Nov 27, 2018

@@ -1,7 +1,7 @@
Tomer Doron <tomerd@apple.com> <tomer.doron@gmail.com>
Tomer Doron <tomerd@apple.com>
Max Moiseev <moiseev@apple.com>
Johannes Weiß <johannesweiss@apple.com>
Johannes Weiss <johannesweiss@apple.com> Johannes Weiß <johannesweiss@apple.com>

This comment has been minimized.

@Lukasa

Lukasa Nov 27, 2018

Contributor

This change brought to you by HM Government.

This comment has been minimized.

@weissi

weissi Nov 27, 2018

Contributor

😂

@Lukasa

Lukasa approved these changes Nov 27, 2018

@helje5

This comment has been minimized.

Contributor

helje5 commented Nov 27, 2018

Why ASCII your name when we just got efficient UTF-8 strings?

@weissi

This comment has been minimized.

Contributor

weissi commented Nov 27, 2018

Why ASCII your name when we just got efficient UTF-8 strings?

stuff breaks, such as git's .mailmap :(

@helje5

This comment has been minimized.

Contributor

helje5 commented Nov 27, 2018

Doesn't that imply you have to ASCII me as well?

@weissi

This comment has been minimized.

Contributor

weissi commented Nov 27, 2018

@helje5 so far we didn't .mailmap coalesce your name yet :). I have used both spellings in various places so want to coalesce them. You have been more consistent

@weissi weissi merged commit 59b3ac4 into apple:master Nov 28, 2018

3 checks passed

pull request validation (4.0.3) Build finished.
Details
pull request validation (4.1) Build finished.
Details
pull request validation (4.2) Build finished.
Details

@weissi weissi deleted the weissi:jw-uc branch Nov 28, 2018

@weissi weissi added this to the 1.12.0 milestone Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment