New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change newPromise(for: T.Type) to newPromise(of: T.Type) #672

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@weissi
Contributor

weissi commented Nov 28, 2018

Motivation:

making a promise of a type is more grammatical than making a promise for
a type.

Modifications:

s/newPromise(for/newPromise(of/g

Result:

  • more grammar
  • note: this is not a public API change because newPromise(for:) has not been released yet.

@weissi weissi requested review from normanmaurer and Lukasa Nov 28, 2018

change newPromise(for: T.Type) to newPromise(of: T.Type)
Motivation:

making a promise of a type is more grammatical than making a promise for
a type.

Modifications:

s/newPromise(for/newPromise(of/g

Result:

more grammar

@weissi weissi force-pushed the weissi:jw-of-not-for branch from 628588d to f3d4401 Nov 28, 2018

@ktoso

ktoso approved these changes Nov 28, 2018

Reads much nicer 👍

@Lukasa

Lukasa approved these changes Nov 28, 2018

@Lukasa Lukasa merged commit a20e129 into apple:master Nov 28, 2018

3 checks passed

pull request validation (4.0.3) Build finished.
Details
pull request validation (4.1) Build finished.
Details
pull request validation (4.2) Build finished.
Details

@weissi weissi added this to the 1.12.0 milestone Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment