New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SwiftPM's linker settings #705

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Contributor

weissi commented Dec 14, 2018

use SwiftPM's linker settings to link zlib

Motivation:

SwiftPM recently introduced a feature that allows you to link libraries
without special system libraries.

Modifications:

make CNIOZlib link zlib directly

Result:

fewer repositories

@weissi weissi force-pushed the weissi:jw-sys-mods branch from 3289848 to 11ab5e0 Jan 7, 2019

@weissi weissi changed the title ❗️ DO NOT MERGE ❗️: use SwiftPM system modules use SwiftPM Jan 7, 2019

@weissi weissi changed the title use SwiftPM use SwiftPM's linker settings Jan 7, 2019

@weissi weissi requested a review from Lukasa Jan 7, 2019

use SwiftPM's linker settings to link zlib
Motivation:

SwiftPM recently introduced a feature that allows you to link libraries
without special system libraries.

Modifications:

make CNIOZlib link zlib directly

Result:

fewer repositories

@weissi weissi force-pushed the weissi:jw-sys-mods branch from 11ab5e0 to 55a4530 Jan 7, 2019

@weissi weissi added this to the 2.0.0 milestone Jan 7, 2019

@Lukasa

Lukasa approved these changes Jan 7, 2019

Copy link
Contributor

Lukasa left a comment

Hooray!

@Lukasa Lukasa merged commit 9c93d6e into apple:master Jan 7, 2019

1 check passed

pull request validation (5.0) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment