Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GitHub files to .github folder #71

Merged
merged 2 commits into from Mar 2, 2018

Conversation

Projects
None yet
4 participants
@BasThomas
Copy link
Contributor

BasThomas commented Mar 2, 2018

This cleans up the root directory by moving ISSUE_TEMPLATE.md, PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md to a dedicated .github folder.

Motivation:

Makes the files more discoverable and cleans up the root directory.

Modifications:

[Describe the modifications you've done.]

Result:

This does not have an impact on how GitHub handles these files.

@swift-nio-bot

This comment has been minimized.

Copy link

swift-nio-bot commented Mar 2, 2018

Can one of the admins verify this patch?

@Lukasa
Copy link
Contributor

Lukasa left a comment

Thanks so much! I didn’t know about this at all, that’s really cool 😎. In general I’m happy with this, but can we keep the CONTRIBUTING.md at the root? That wasn’t actually intended as a Github special file; we wrote it for general consumption.

@BasThomas

This comment has been minimized.

Copy link
Contributor Author

BasThomas commented Mar 2, 2018

Done! :)

@Lukasa

Lukasa approved these changes Mar 2, 2018

Copy link
Contributor

Lukasa left a comment

Beautiful, looks great. 😁

@Lukasa

This comment has been minimized.

Copy link
Contributor

Lukasa commented Mar 2, 2018

@swift-nio-bot test this please

@Lukasa Lukasa merged commit 16cf264 into apple:master Mar 2, 2018

1 check passed

pull request validation Build finished.
Details

@normanmaurer normanmaurer added this to the 1.1.0 milestone Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.