New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list_topsorted_dependencies script. #723

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@Lukasa
Copy link
Contributor

Lukasa commented Jan 2, 2019

Motivation:

Newer versions of SwiftPM for the Swift 5 release have changed the output
format of swift package dump-package. This has broken our
list_topsorted_dependencies script. This script is highly useful, so we'd
like to keep it working.

The discussion on SR-9191 suggests that SwiftPM considers this format
changeable at any time, so we may need to make a change like this in future.
We may want to consider writing tests for this script to ensure its continued good functioning.

Modifications:

  • Amended the jq scripts to parse the new JSON format.

Result:

list_topsorted_dependencies will work with Swift 5 development copies of
SwiftPM. Note that this will break this script with earlier copies of SwiftPM,
but as we only support Swift 5 on the master branch this change is safe to
make.

Update list_topsorted_dependencies script.
Motivation:

Newer versions of SwiftPM for the Swift 5 release have changed the output
format of swift package dump-package. This has broken our
list_topsorted_dependencies script. This script is highly useful, so we'd
like to keep it working.

The discussion on SR-9191 suggests that SwiftPM considers this format
changeable at any time, so we may need to make a change like this in future.
We may want to consider writing tests for this script to ensure its continued good functioning.

Modifications:

- Amended the jq scripts to parse the new JSON format.

Result:

list_topsorted_dependencies will work with Swift 5 development copies of
SwiftPM. Note that this will break this script with earlier copies of SwiftPM,
but as we only support Swift 5 on the master branch this change is safe to
make.

@Lukasa Lukasa added this to the 2.0.0 milestone Jan 2, 2019

@Lukasa Lukasa requested a review from weissi Jan 2, 2019

@weissi

weissi approved these changes Jan 2, 2019

Copy link
Contributor

weissi left a comment

thanks, lgtm

@weissi weissi merged commit 3659a4a into apple:master Jan 2, 2019

1 check passed

pull request validation (5.0) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment