New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise Swift 5 ByteBuffer read/write allocation limit #729

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Contributor

weissi commented Jan 2, 2019

Motivation:

Swift 5 contains a regression where we get 1 extra allocations for the
ByteBuffer read/write allocation test.

I will track this problem down (#727 with a bit of luck, it's the same as #726) but for now it's important to unblock
other NIO2 work.

Modifications:

raise the allowed allocations for the ByteBuffer RW test by 1

Result:

allocation tests can be re-enabled again.

Johannes Weiss
raise Swift 5 ByteBuffer read/write allocation limit
Motivation:

Swift 5 contains a regression where we get 1 extra allocations for the
ByteBuffer read/write allocation test.

I will track this problem down but for now it's important to unblock
other NIO2 work.

Modifications:

raise the allowed allocations for the ByteBuffer RW test by 1

Result:

allocation tests can be re-enabled again.

@weissi weissi requested a review from Lukasa Jan 2, 2019

@Lukasa Lukasa added this to the 2.0.0 milestone Jan 3, 2019

@Lukasa

Lukasa approved these changes Jan 3, 2019

@Lukasa Lukasa merged commit 3ce1c25 into apple:master Jan 3, 2019

1 check passed

pull request validation (5.0) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment